WIP: Support for Voltronic Axpert P30 protocol inverters (main) #1407
+4,577
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for the Voltronic Axpert inverters based on the P30 protocol. Updated the nutdrv_qx driver to support the optional sending of commands protected by CRC. Initial support for query commands. Based on work done in the Voltronic Sunny driver in https://github.com/nickma82/nut/tree/nutdrv_qx_voltronic-sunny_rebased+command Still TODO: Implement commands to write to the inverter. Remove commented code originating from sunny driver. Further testing. Update docs (manpages, acknowledgements...)
|
This pull request introduces 1 alert when merging 5375524 into 9cb8de6 - view on LGTM.com new alerts:
|
Comparison between byte of type unsigned short and len of wider type size_t
|
@minfrin : I marked the PR as draft for now, so it would not burden CI with failing code to build ephemeral merges as master branch marches on. Feel free to un-set draft mode when needed to test fixes to broken builds. |
|
Thanks for this. All the parameters being read are working well, and it's doing the job. Testing the write functions is tricky, as the inverter is powering the machine it was developed on, so options are limited. Lining up a time to do safe testing. |
|
Cheers! Wondering if you have any updates on this? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the Voltronic Axpert inverters based on the P30 protocol.
Updated the nutdrv_qx driver to support the optional sending of commands
protected by CRC.
Initial support for query commands. Based on work done in the Voltronic
Sunny driver in https://github.com/nickma82/nut/tree/nutdrv_qx_voltronic-sunny_rebased+command
Still TODO:
Implement commands to write to the inverter.
Remove commented code originating from sunny driver.
Further testing.
Update docs (manpages, acknowledgements...)