Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scope support on apply change set #64

Merged

Conversation

mfiedorowicz
Copy link
Member

This pull request includes several changes to the netbox_diode_plugin to improve the handling of object types and scopes, as well as updates to the test suite to cover new functionality. The most important changes include updating methods to handle both string and NetBoxType object types, refining scope handling logic, and adding new test cases.

Updates to object type handling:

Refinement of scope handling:

Test suite improvements:

Signed-off-by: Michal Fiedorowicz <[email protected]>
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1472 1424 97% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
netbox_diode_plugin/api/views.py 92% 🟢
netbox_diode_plugin/tests/test_api_apply_change_set.py 100% 🟢
TOTAL 96% 🟢

updated for commit: 65d245c by action🐍

@mfiedorowicz mfiedorowicz merged commit 93e4c9b into feat-diode-data-plugin Feb 20, 2025
2 checks passed
@mfiedorowicz mfiedorowicz deleted the fix-apply-change-set-scope-support branch February 20, 2025 13:57
ltucker pushed a commit that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants