Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not treat _branch parameter as search criterion #52

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

ltucker
Copy link

@ltucker ltucker commented Dec 13, 2024

Ignores netbox_branching plugin _branch parameter when collecting additional search criteria from query parameters in the diode/object-state/ endpoint.

Previously, a call containing search criteria and the _branch parameter would return

{"errors":["invalid additional attributes provided"]}

Copy link

github-actions bot commented Dec 13, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1739 1720 99% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
netbox_diode_plugin/api/views.py 96% 🟢
netbox_diode_plugin/tests/test_api_object_state.py 100% 🟢
TOTAL 98% 🟢

updated for commit: e408ce5 by action🐍

Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@ltucker ltucker merged commit 3477b04 into feat-diode-data-plugin Dec 13, 2024
2 checks passed
@ltucker ltucker deleted the branch_aware branch December 13, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants