Compatibility for numpy 2.0 #3265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a lot of tiny file changes because of the new ruff lint version |
|
See #2726 (comment) I am fine with moving forward with newer version of opencv. |
brentyi
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for supporting numpy 2.0. Our builds were breaking because of numpy 2.0, I added the automatic ruff linting as described here, and also upgraded OpenCV to 4.10 as described here.
@jb-ye @f-dy I seem to remember there was some reason we pinned OpenCV to 4.8 related to the undistorting code, do you know if that's still important?