This repository has been archived by the owner on Jul 12, 2019. It is now read-only.
feat(demo): pass navigation to demo render function #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levito
commented
Jun 8, 2017
| @@ -7,20 +7,22 @@ import { colors } from '../../../themes'; | |||
| export type DemoRendererProps = { | |||
| isFullScreen?: boolean, | |||
| render: () => React.Element<*>, | |||
| navigation: Object, | |||
There was a problem hiding this comment.
This should be stronger typed than Object
levito
force-pushed
the
demo-render-with-navigation
branch
from
8456a91 to
5fac85e
Compare
So a demo can use things like navigation.goBack() which is useful for full-screen demos without header or back button.
levito
force-pushed
the
demo-render-with-navigation
branch
from
5fac85e to
ccf8918
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So a demo can use things like navigation.goBack() which is useful for
full-screen demos without header or back button.