Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(texlab): remove deprecated texlab.auxDirectory #3255

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Thibaulltt
Copy link
Contributor

I noticed this while debugging some texlab problems.

The configuration key 'texlab.auxDirextory' has been deprecated, in favor of 'texlab.build.auxDir', mirroring the latexmkrc's auxDir variable.

see: https://github.com/latex-lsp/texlab/wiki/Configuration#deprecated-texlabauxdirectory

@justinmk
Copy link
Member

justinmk commented Oct 1, 2024

needs a rebase, the server_configurations/ directory was renamed to configs/ #3330

The configuration key 'texlab.auxDirextory' has been deprecated, in
favor of 'texlab.build.auxDir', mirroring the latexmkrc's auxDir
variable.

see: https://github.com/latex-lsp/texlab/wiki/Configuration#deprecated-texlabauxdirectory
@Thibaulltt
Copy link
Contributor Author

Hi, forgot to push my commit a couple weeks ago and had to rebase again. Should be good to go now :)

@justinmk justinmk changed the title draft: fix(texlab): remove deprecated texlab.auxDirectory fix(texlab): remove deprecated texlab.auxDirectory Oct 14, 2024
@justinmk
Copy link
Member

The configuration key 'texlab.auxDirextory' has been deprecated, in favor of 'texlab.build.auxDir', mirroring the latexmkrc's auxDir variable.

This PR didn't add 'texlab.build.auxDir' though. Is that intentional, not needed, or why? Always helpful to concisely mention that in a commit message / pr description.

@Thibaulltt
Copy link
Contributor Author

Sorry for not mentionning it. It has a default value of . in texlab if not explicitly set, or if the user has no latexmkrc file. Since I use a latexmkrc file myself, this is auto-magically populated with the right value :)

Source: https://github.com/latex-lsp/texlab/wiki/Configuration#texlabbuildauxdirectory

@Thibaulltt
Copy link
Contributor Author

Should I maybe include it anyway and let the user override it in their own setup({...}) call? Leaving it blank always ensures texlab is the one responsible for it, but I'd understand if you wanted a more complete config in this repo.

@justinmk
Copy link
Member

It's good to delegate to defaults where possible, we just need to mention that for future reference, when we change things. I will add your note to the commit message.

@justinmk justinmk merged commit d0ea4cd into neovim:master Oct 14, 2024
11 checks passed
@Thibaulltt Thibaulltt deleted the texlab-remove-auxdir branch November 3, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants