Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checklist from the PR template #9702

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Nov 8, 2024

Problem

Once we enable the merge queue for the main branch, it won't be possible to adjust the commit message right after pressing the "Squash and merge" button, and the PR title + description will be used as is.

To avoid extra noise in the commits in the main with checklist leftovers, I propose removing the checklist from the PR template, and keeping only the Problem / Summary of changes.

Summary of changes

  • Remove the checklist from the PR template

Copy link

github-actions bot commented Nov 8, 2024

5381 tests run: 5158 passed, 1 failed, 222 skipped (full report)


Failures on Postgres 17

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_sharding_split_failures[debug-pg17-failure8]"
Flaky tests (3)

Postgres 17

Postgres 15

Code coverage* (full report)

  • functions: 31.7% (7871 of 24806 functions)
  • lines: 49.4% (62275 of 126036 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
56bc420 at 2024-11-10T23:18:11.975Z :recycle:

@bayandin bayandin force-pushed the bayandin/remove-checklist-from-pr-template branch from 24f4a15 to 56bc420 Compare November 9, 2024 01:11
@bayandin bayandin requested review from a team, myrrc, problame and cloneable and removed request for a team November 10, 2024 22:38
@bayandin bayandin marked this pull request as ready for review November 10, 2024 22:38
@bayandin bayandin changed the title Remove checklist from PR template Remove checklist from the PR template Nov 10, 2024
@bayandin bayandin merged commit 1aab347 into main Nov 11, 2024
82 checks passed
@bayandin bayandin deleted the bayandin/remove-checklist-from-pr-template branch November 11, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants