Allow compilation without "docker buildx" #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't have "docker buildx" CLI installed on my system. I could install it, but it's easy to avoid the dependency, so let's do that instead and save one step for anyone new trying to build this.
Omrigan
reviewed
Jun 19, 2024
| @@ -145,30 +145,28 @@ docker-push: docker-build ## Push docker images to docker registry | |||
|
|
|||
| .PHONY: docker-build-controller | |||
| docker-build-controller: ## Build docker image for NeonVM controller | |||
| docker build --build-arg VM_RUNNER_IMAGE=$(IMG_RUNNER) --build-arg BUILDTAGS=$(if $(PRESERVE_RUNNER_PODS),nodelete) -t $(IMG_CONTROLLER) -f neonvm/Dockerfile . | |||
| DOCKER_BUILDKIT=1 docker build --build-arg VM_RUNNER_IMAGE=$(IMG_RUNNER) --build-arg BUILDTAGS=$(if $(PRESERVE_RUNNER_PODS),nodelete) -t $(IMG_CONTROLLER) -f neonvm/Dockerfile . | |||
There was a problem hiding this comment.
Is DOCKER_BUILDKIT=1 really needed? I googled, and it says docker has it by default in the current version (v23.0+)
There was a problem hiding this comment.
Is DOCKER_BUILDKIT=1 really needed? I googled, and it says docker has it by default in the current version (v23.0+)
Debian bookworm comes with an older version:
$ docker --version
Docker version 20.10.24+dfsg1, build 297e128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have "docker buildx" CLI installed on my system. I could install it, but it's easy to avoid the dependency, so let's do that instead and save one step for anyone new trying to build this.