neonvm-controller: Fix overwriting runner version #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed while working on #738. In short, because the runner API version was part of labelsForVirtualMachine, any update to the runner version would be updated for *all* VM pods, not just new one. This is (probably) not an issue in prod right now, but could be an issue for future changes. Right now, #738 would trigger this bug, but remain unaffected (it doesn't have version-dependent logic *currently*). This PR fixes the behavior by adding the runner API version as an explicit argument to labelsForVirtualMachine and ignoring the label in updatePodMetadataIfNecessary.
Omrigan
reviewed
Jan 22, 2024
Omrigan
approved these changes
Jan 22, 2024
shayanh
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while working on #738. In short, because the runner API version was part of
labelsForVirtualMachine, any update to the runner version would be updated for all VM pods, not just new one.This is (probably) not an issue in prod right now, but could be an issue for future changes.
Right now, #738 would trigger this bug, but remain unaffected (it doesn't have version-dependent logic currently).This PR fixes the behavior by adding the runner API version as an explicit argument to
labelsForVirtualMachineand ignoring the label inupdatePodMetadataIfNecessary.Notes for review: Planning to merge 48h after 1 approval, or 24h after 2 approvals. Want to give people a chance to take a look, but overall change is not too complex.