neonvm: drop generated default value in CRD #1313
Merged
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No changes to the coverage.
HTML Report |
sharnoff
approved these changes
Mar 11, 2025
mikhail-sakhnov
changed the title
mikhail-sakhnov
changed the title
mikhail-sakhnov
force-pushed
the
misha/drop-default-scaling-mode-via-kubebuilder
branch
from
14f5a33 to
f5d347d
Compare
We use kubebuilder:default annotation for scaling mode fields, which effiectively means we never allow it to be non set and that bypasses the logic with --default-cpu-scaling-mode controller argument
mikhail-sakhnov
force-pushed
the
misha/drop-default-scaling-mode-via-kubebuilder
branch
from
f5d347d to
f355bc8
Compare
mikhail-sakhnov
force-pushed
the
misha/drop-default-scaling-mode-via-kubebuilder
branch
from
82cfce7 to
90a2da7
Compare
mikhail-sakhnov
deleted the
misha/drop-default-scaling-mode-via-kubebuilder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use kubebuilder:default annotation for scaling mode fields, which effiectively means we never allow it to be non set and that bypasses the logic with --default-cpu-scaling-mode controller argument