neonvm: handle sysfs scaling mode in migrations #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhail-sakhnov
force-pushed
the
misha/fix-migration-controller-scaling
branch
from
b6ff9d4 to
dac0c41
Compare
No changes to the coverage.
HTML Report |
mikhail-sakhnov
force-pushed
the
misha/fix-migration-controller-scaling
branch
from
dac0c41 to
73b56a9
Compare
sharnoff
reviewed
Jan 21, 2025
Omrigan
reviewed
Jan 21, 2025
If source VM uses sysfs cpu scaling mode we don't need to perform any QMP related sync operations during the migration Signed-off-by: Misha Sakhnov <[email protected]>
mikhail-sakhnov
force-pushed
the
misha/fix-migration-controller-scaling
branch
from
73b56a9 to
4724f6b
Compare
Omrigan
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to sync CPUs only if we have QMP mode active. For sysfs scaling CPU state should sync automatically.
Related to #850 and #1111