Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] modernize #359

Merged
merged 9 commits into from
Jan 13, 2025
Merged

[ci] modernize #359

merged 9 commits into from
Jan 13, 2025

Conversation

dnicolodi
Copy link
Collaborator

@dnicolodi dnicolodi commented Jan 8, 2025

The main goals of this PR are: update outdated actions, reduce the runtime, streamline and simplify. Not installing unnecessary packages and not updating the installation with apt reduces the tests runtime from above 6 minutes to less than a minute.

@dnicolodi dnicolodi marked this pull request as draft January 8, 2025 21:16
@dnicolodi dnicolodi force-pushed the modernize-ci branch 9 times, most recently from 296bf41 to bfabee3 Compare January 8, 2025 22:03
@dnicolodi dnicolodi marked this pull request as ready for review January 8, 2025 22:07
@dnicolodi dnicolodi changed the title Modernize CI [ci] modernize Jan 8, 2025
@apalala
Copy link
Collaborator

apalala commented Jan 13, 2025

This looks good.

@dnicolodi, you can now create branches on the TatSu repo so others can test the changes before merging to master.

@dnicolodi
Copy link
Collaborator Author

Thanks for the trust, @apalala

I don't want to state the obvious, but all PR can be accessed as branches of the destination repository. The branch name is refs/pull/$id/head where $id is the PR numeric identifier.

@apalala
Copy link
Collaborator

apalala commented Jan 13, 2025

I don't want to state the obvious, but all PR can be accessed as branches of the destination repository. The branch name is refs/pull/$id/head where $id is the PR numeric identifier.

This worked:

gh pr checkout 359

@apalala apalala merged commit 4d0ea4f into neogeny:master Jan 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants