Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread-safe edge mutation #114

Merged
merged 15 commits into from
Nov 3, 2023
Merged

Thread-safe edge mutation #114

merged 15 commits into from
Nov 3, 2023

Conversation

s1ck
Copy link
Collaborator

@s1ck s1ck commented Oct 31, 2023 •
edited
Loading

No description provided.

@s1ck s1ck requested a review from knutwalker October 31, 2023 12:13
@s1ck s1ck mentioned this pull request Oct 31, 2023
Merged
knutwalker
knutwalker approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@knutwalker knutwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, i have a few remarks.

This does not include the single-threaded API that we talked about, do you plan to add this at some point? Or maybe I missed it 🤔

crates/builder/src/graph/adj_list.rs Outdated Show resolved Hide resolved
crates/builder/src/graph/adj_list.rs Outdated Show resolved Hide resolved
crates/builder/src/graph/adj_list.rs Outdated Show resolved Hide resolved
crates/builder/src/graph/adj_list.rs Outdated Show resolved Hide resolved
crates/builder/src/graph/adj_list.rs Show resolved Hide resolved
crates/builder/src/graph/adj_list.rs Outdated Show resolved Hide resolved
crates/builder/src/graph/adj_list.rs Show resolved Hide resolved
crates/builder/src/prelude.rs Show resolved Hide resolved
crates/builder/src/lib.rs Show resolved Hide resolved
@s1ck
Copy link
Collaborator Author

s1ck commented Nov 3, 2023

@knutwalker Thanks for the review!

@s1ck s1ck merged commit 23e805a into main Nov 3, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knutwalker knutwalker knutwalker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s1ck @knutwalker