Fixed issue #9 #10
Closed
Fixed issue #9 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, there is a lot of unrelated changes and debug comments still in there. Did you also consider the case when there is no mapping passed in? B/c that's what the |
jexp
reviewed
Sep 10, 2018
|
|
||
| // const column=(rMapping[key]||key).toString(); // original | ||
| // console.log("Correcting the key mapping data with const column = mapping[key].toString() is " + (mapping[key]).toString()) | ||
| const column = mapping[key].toString() |
There was a problem hiding this comment.
what happens if there is no entry for key in the mapping? Then the original name from the mutation args has to be used.
|
Please remove all the debug logs, commented out code and whitespace changes, otherwise it's really hard to review the changes. |
|
I had an error with my reference of the json columns, so there was no problem with the source code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in this issue #9 , I was trying to run this command in the most minimal Prisma example which I created here:
With the original graphql-cli-load code, I got this error:
After a lot of research into your source code, I recognized the syntax error was because there was no mapped mutations being built inside
buildMutations, and then saw that therMappingwas calling the wrong "key" to select thevaluesfrom the given csvrows. Changing this to the originalmapping, the whole graphql-cli-load worked properly.