Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deps): removing fbjs dependency by creating a local module for invariant and warning #2727

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mateoguzmana
Copy link

@mateoguzmana mateoguzmana commented Oct 19, 2024

As part of #2333, invariant and warning are the last two dependencies in the project used from fbjs and removing them allows removing that external dependency.

In this PR:

  • Local module for invariant and replacing the imports
  • Local module for warning which had another dependency of emptyFunction hence it has been added as well.
  • fbjs dependency has been removed from packages/react-native-web/package.json.

I can still see fbjs in the main package-lock.json as there are other packages within the repo that have react-native-web installed as a dependency, hence it might potentially be removed once that dependency is upgraded as well.

Ps: I did the replacement of warning in the same PR as it was fairly small, but happy to split this up in another PR if needed.

@mateoguzmana mateoguzmana marked this pull request as ready for review October 19, 2024 11:03
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e65e598:

Sandbox Source
react-native-web-examples Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant