Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure the PR is against the
develop
branch (see Contributing).Make sure to set the corresponding milestone in the PR.
This change makes
scout
the entrypoint of the Docker image.Before this change the image would start a bash prompt.
After this change the image image is running scout directly and can be used for example like this:
docker run --rm -it -v "$HOME/.aws:/root/.aws" -v "$(pwd):/out" scoutsuite aws --no-browser --report-dir /out/ --report-name test
.This makes it easier to run and reproducible.
To get the old behaviour the entrypoint can be overridden with
docker run --entrypoint /bin/bash scoutsuite
This change also sets the
VERSION
variable in theconfig/build.env
to be based off the git branch/tag.Type of change
Select the relevant option(s):
The wiki will need to be updated on how to run the image.
It is currently mildly out of date already as it includes instructions for entering the virtual-env which is already done by the way the image is built.
Checklist: