Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create codeql-analysis.yml #1

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Create codeql-analysis.yml #1

wants to merge 4 commits into from

Conversation

rocketnova
Copy link
Contributor

Ticket

  • N/A

Changes

What was added, updated, or removed in this PR.

  • Setup Github's CodeQL code scanning

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

Testing

Screenshots, GIF demos, code examples or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox.

strategy:
fail-fast: false
matrix:
language: [ 'python' ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit can we consistently use single quotes or double quotes in the file

# the `language` matrix defined below to confirm you have the correct set of
# supported CodeQL languages.
#
name: "CodeQL"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a preference for naming things based on their semantics rather than the brand name of the library, could we name the job (and the workflow yaml file) something like Analyze Code Vulnerabilities or Vulnerability Scan or something

@chouinar chouinar removed their request for review July 3, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants