Skip to content

Commit

Permalink
Bump Python version in pyproject.toml (#226)
Browse files Browse the repository at this point in the history
## Ticket

n/a

## Changes

Changes minimum Python version in pyproject.toml to 3.12.
Fixes two minor unrelated typos in documentation.

## Context for reviewers

The repo includes a `.python-version` set to 3.12, so the minimum
version Poetry requires of dependencies should match.

Alternatively, we could downgrade the .python-version to 3.10, but that
seems unnecessary.

## Testing

All existing tests pass.
  • Loading branch information
KevinJBoyer authored Jun 6, 2024
1 parent 5730b46 commit cbcc8d8
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 41 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ To get started using the template application on your project:

## Note on memory usage

If you are using [template-infra](https://github.com/navapbc/template-infra), you may want to increase the [default memory](https://github.com/navapbc/template-infra/blob/main/infra/modules/service/variables.tf#L33) allocated to the ECS service to 2048 Mb (2 Gb) to avoid the gunicorn workers running out of memory. This is because the application is currently [configured to create multiple workers](https://github.com/navapbc/template-application-flask/blob/main/app/gunicorn.conf.py#L24) based on the numberr of virtual CPUs available, which can take up more memory.
If you are using [template-infra](https://github.com/navapbc/template-infra), you may want to increase the [default memory](https://github.com/navapbc/template-infra/blob/main/infra/modules/service/variables.tf#L33) allocated to the ECS service to 2048 Mb (2 Gb) to avoid the gunicorn workers running out of memory. This is because the application is currently [configured to create multiple workers](https://github.com/navapbc/template-application-flask/blob/main/app/gunicorn.conf.py#L24) based on the number of virtual CPUs available, which can take up more memory.

## Getting started

Expand Down
2 changes: 1 addition & 1 deletion app/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ RUN poetry install --no-root --only main
RUN poetry build --format wheel && poetry run pip install 'dist/template_application_flask-0.1.0-py3-none-any.whl'

# Add project's virtual env to the PATH so we can directly run poetry scripts
# defiend in pyproject.toml
# defined in pyproject.toml
ENV PATH="/app/.venv/bin:$PATH"

# Set the host to 0.0.0.0 to make the server available external
Expand Down
42 changes: 4 additions & 38 deletions app/poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion app/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ packages = [{ include = "src" }]
authors = ["Nava Engineering <[email protected]>"]

[tool.poetry.dependencies]
python = "^3.10"
python = "^3.12"
SQLAlchemy = {version = "^2.0.21", extras = ["mypy"]}
alembic = "^1.12.0"
python-dotenv = "^1.0.0"
Expand Down

0 comments on commit cbcc8d8

Please sign in to comment.