Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing template-infra#474 #65

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Testing template-infra#474 #65

wants to merge 3 commits into from

Conversation

rocketnova
Copy link
Contributor

@rocketnova rocketnova commented Nov 14, 2023

Ticket

N/A

Changes

What was added, updated, or removed in this PR.

  • Add a test docker image specifically for testing the changes in 474

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers.

This PR is for testing the changes proposed in navapbc/template-infra#474.

Testing

Provide evidence that the code works as expected. Explain what was done for testing and the results of the test plan. Include screenshots, GIF demos, shell commands or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox.

This PR changes /infra/app/services/main.tf to use a different configuration that exercises the functionality added in 474. Specifically, it uses a separate docker image (https://hub.docker.com/r/rocketnovadockerhub/tiny-env-test) which should (if everything is set up correctly) show something like this:

Hello, World!

Custom env var: 100

Custom secret: 200

Testing steps:

  1. Deploy these changes. I used make infra-update-app-service APP_NAME=app ENVIRONMENT=dev
  2. Navigate to the ECS task's LB url. It should display something like the above (showing whatever value you set the Parameter Store secret to)

@rocketnova rocketnova changed the title Rocket/test 474 Testing template-infra#474 Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant