Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent CPU Mem Monitor Blocking on Startup #764

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

bcoltin
Copy link
Member

@bcoltin bcoltin commented Feb 9, 2024

Starts a separate thread to get all PIDs so the heartbeat can be published immediately.

Copy link
Member

@marinagmoreira marinagmoreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! was this tested on the robot?

@bcoltin
Copy link
Member Author

bcoltin commented Feb 9, 2024

No, only on the simulator. Should we wait to merge until testing on the robot? Probably makes more sense to wait until next testing session rather than going to lab just for this.

@marinagmoreira
Copy link
Member

No, only on the simulator. Should we wait to merge until testing on the robot? Probably makes more sense to wait until next testing session rather than going to lab just for this.

no worries, I'll test it quickly and merge this in :)

@bcoltin
Copy link
Member Author

bcoltin commented Feb 9, 2024

Thanks!

@marinagmoreira
Copy link
Member

tested in the lab

@marinagmoreira marinagmoreira merged commit 3da8b0f into nasa:develop Feb 12, 2024
4 checks passed
@bcoltin
Copy link
Member Author

bcoltin commented Feb 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants