fix proptypes, update react class, and content height #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set height when toggle to update content height
reset height if refresh is true
|
I couldn't get the accordion working for my app and I stumbled upon your pull request for the fixed version for the new react native. Thank you for implementing this! The repo owner doesn't seem to be active on maintaining it. |
|
@Tarek98 thank you! I'm interested in maintaining this repo if the owner can add me as a collaborator. As for now I'm open to receiving new suggestions, any bug fixes etc. in my forked repo so feel free to add your comments under the "Issues" tab there :) |
connorbrathwaite
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnimatedThis PR should fix issues happening in the old release.
@naoufal