Compojoom fixes #52
Open
Compojoom fixes #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
automatically re-calculate the height when the content updates.
Cherry picking from 8a801c7 and b6dc745 naoufal#38
on content change
Android fixes for the content height adding the fixes specified in this issue: naoufal#19 without them the content item is behind the currently open element
Adding onEnd property Helps when you need something to update in response of the open/close of the accordion.
You can not have 2 touchable element nested in each other and have them behave as expected. That’s why if we want to react on onPress and onLongPress we have to do it on the same touchable element.
…show the correct open header when we first render the component
0.0.5 was showing an isMounted warning with the latest RN
|
This should seriously be merged in. I just had to specify @compojoom's branch in npm to get this thing to work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.