Add empty onLayout functions on views so they can be measured on android #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamrainsby Can you give me more context around the fix? |
|
@naoufal See this issue facebook/react-native#3282 Measure doesn't work on android without it. |
compojoom
pushed a commit
to compojoom/react-native-accordion
that referenced
this pull request
Mar 1, 2017
adding the fixes specified in this issue: naoufal#19 without them the content item is behind the currently open element
compojoom
added a commit
to compojoom/react-native-accordion
that referenced
this pull request
Mar 1, 2017
Android fixes for the content height adding the fixes specified in this issue: naoufal#19 without them the content item is behind the currently open element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a weird bug where you can't measure views on android if the view doesn't specify an onLayout function