allow nanos-version to be used in cross-arch #1527
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not just use -arm64 as local folder to make sure the arch is specifically 64 bit? |
|
we do do this already, just not everything conforms to it yet, the set of possible runs are:
so we want sane defaults everywhere (eg: default to user's native platform) but allow them to override as they see fit |
|
I get it but the PR basically adds |
|
i see what you are saying - nanos is 64bit only - we don't have plans for ever adding 32bit; this pr is kinda dead regardless; i'll need to revisit it once i find some time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.