Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bexley] Add payment fallback script #5340

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dracos
Copy link
Member

@dracos dracos commented Jan 27, 2025

For https://github.com/mysociety/societyworks/issues/4681 [skip changelog]

Doesn't actually include any Bexley specific tests/stuff, that should be added when payments are added in some other work. This is being used by Merton (and can be used by any SCP usage, which Bexley is).

@dracos dracos requested a review from davea January 27, 2025 09:47
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 78.84615% with 11 lines in your changes missing coverage. Please review.

Project coverage is 82.33%. Comparing base (449245f) to head (5fd1b46).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
perllib/FixMyStreet/Roles/Cobrand/Paye.pm 71.42% 3 Missing and 3 partials ⚠️
perllib/FixMyStreet/Script/Waste/CheckPayments.pm 78.57% 1 Missing and 2 partials ⚠️
perllib/FixMyStreet/Script/Merton/SendWaste.pm 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5340      +/-   ##
==========================================
+ Coverage   82.30%   82.33%   +0.02%     
==========================================
  Files         425      426       +1     
  Lines       33518    33546      +28     
  Branches     5403     5406       +3     
==========================================
+ Hits        27587    27620      +33     
+ Misses       4333     4325       -8     
- Partials     1598     1601       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dracos dracos force-pushed the bexley-ww-garden-payment-fallback branch from 66296b5 to 5fd1b46 Compare March 6, 2025 16:41
@dracos dracos requested a review from chrismytton March 6, 2025 16:41
@dracos
Copy link
Member Author

dracos commented Mar 6, 2025

I've just pushed an extra commit on this to include apnReference support (as left by PAYE payments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants