Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--list and --productid options added #25

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tperfitt
Copy link

@tperfitt tperfitt commented Oct 8, 2019

Add in the following options:

--list : output just a list of OS's and exit in plist format.
--productid: select the productid from the list

moved check for uid 0 to after check for list option since root is not required for that.

changed all info messages to stderr since stdout is used for outputting plist.

@grahampugh
Copy link

@tperfitt in case you’re interested, my fork at https://github.com/grahampugh/macadmin-scripts already has —list and —build options.

@@ -262,7 +262,7 @@ def replicate_url(full_url,
if attempt_resume:
curl_cmd.extend(['-C', '-'])
curl_cmd.append(full_url)
print("Downloading %s..." % full_url)
print("Downloading %s..." % full_url, file=sys.stderr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. I know why you want this; I just have a philosophical issue with directing non-error messages to stderr. Convince me this is the right thing to do. Is this a common pattern for UNIX/POSIX tools?

Copy link
Contributor

@gregneagle gregneagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See single comment.

@gregneagle gregneagle closed this Jun 15, 2020
@gregneagle gregneagle reopened this Jun 16, 2020
@gregneagle gregneagle changed the base branch from master to main June 16, 2020 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants