Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dialogs close #4707

Merged
merged 3 commits into from
Feb 27, 2025
Merged

Fix dialogs close #4707

merged 3 commits into from
Feb 27, 2025

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Feb 27, 2025

Stabilize the context value. Event handlers are holding references to it and are operating on outdated state. Eventually we should implement it like #4628 but in the meantime this should work.

Closes #4706

@mui-bot
Copy link

mui-bot commented Feb 27, 2025

Netlify deploy preview

https://deploy-preview-4707--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against 132e6d8

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Feb 27, 2025
@Janpot Janpot marked this pull request as ready for review February 27, 2025 10:18
@Janpot Janpot requested a review from bharatkashyap February 27, 2025 10:24
Copy link
Member

@bharatkashyap bharatkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Janpot Janpot merged commit e844d6e into mui:master Feb 27, 2025
15 checks passed
@Janpot Janpot deleted the dialogs-close branch February 27, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useDialogs close function not working as expected
3 participants