[license] Updated the LicenseInfo class with 2 additional checks
#16404
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelengelen
added
package: x-license
michelengelen
requested review from
oliviertassinari,
flaviendelangle and
mapache-salvaje
|
Deploy preview: https://deploy-preview-16404--material-ui-x.netlify.app/ |
Co-authored-by: Sam Sycamore <[email protected]> Signed-off-by: Michel Engelen <[email protected]>
mapache-salvaje
approved these changes
Jan 31, 2025
Co-authored-by: Sam Sycamore <[email protected]> Signed-off-by: Michel Engelen <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]> Signed-off-by: Michel Engelen <[email protected]>
packages/x-license/src/useLicenseVerifier/useLicenseVerifier.ts
Outdated
Show resolved
Hide resolved
Comment on lines
36
to
45
| LicenseInfo.isLicenseKeySet = !!key; | ||
| LicenseInfo.hasSetLicenseKeyRun = true; | ||
| } | ||
|
|
||
| public static getIsLicenseKeySet(): boolean { | ||
| return LicenseInfo.isLicenseKeySet; | ||
| } | ||
|
|
||
| public static getHasSetLicenseKeyRun(): boolean { | ||
| return LicenseInfo.hasSetLicenseKeyRun; |
There was a problem hiding this comment.
We could do this with less code, no?
Suggested change
| LicenseInfo.isLicenseKeySet = !!key; | |
| LicenseInfo.hasSetLicenseKeyRun = true; | |
| } | |
| public static getIsLicenseKeySet(): boolean { | |
| return LicenseInfo.isLicenseKeySet; | |
| } | |
| public static getHasSetLicenseKeyRun(): boolean { | |
| return LicenseInfo.hasSetLicenseKeyRun; | |
| } |
and then
ponyfillGlobal.__MUI_LICENSE_INFO__ = ponyfillGlobal.__MUI_LICENSE_INFO__ || {
- key: undefined,
+ key: 'default',
};There was a problem hiding this comment.
There is one very specific edge-case where this would not be enough:
setLicenseKey was called, but with undefined as parameter.
Not sure if we want to cover that case though ... WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds 2 additional checks to the license check.
setLicenseKeymethod been run at allasking @mapache-salvaje specifically for a review of the error messages 🙇🏼