-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Use renderer interceptor on DateTimePicker
#12441
[pickers] Use renderer interceptor on DateTimePicker
#12441
Conversation
Deploy preview: https://deploy-preview-12441--material-ui-x.netlify.app/ Updated pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement!
Nothing breaking here?
I've checked and it seems that the explicit
@flaviendelangle I've updated the PR description, could you check it? 🤔 |
@LukasTy I think this would be more complete:
=>
And a diff example would probably be a nice addition, both for the changelog and the migration guide |
@flaviendelangle I've updated the PR description and added a migration guide entry. |
True, it's not great to have a BC without a clear diff but maybe it's too much of an headache here |
Follow up on the
DateTimeRangePicker
solution withrendererInterceptor
instead ofdateTimeViewRenderers
.The BC is two-fold:
dateTimeViewRenderers
;renderTimeViewClock
) will no longer revert back to the v5 (v6) behavior, where only date or time view is shown at one time (changed behavior in 1st demo here)Visual BC showcase
Changelog
DesktopDateTimePicker
view rendering has been optimized by using the same technique as forDesktopDateTimeRangePicker
.dateTimeViewRenderers
have been removed in favor of reusing existing time view renderers (renderTimeViewClock
,renderDigitalClockTimeView
andrenderMultiSectionDigitalClockTimeView
) and date view renderer (renderDateViewCalendar
).renderTimeViewClock
to time view renderers will no longer revert to the old behavior of rendering only date or time view.