-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add polish to the date-picker playground #11869
Conversation
@noraleonte I just made some stray tweaks, please let me know if anything needs to be fixed, since this is my first PR for X :) |
Deploy preview: https://deploy-preview-11869--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up, @zanivan 💯 🎉
Looks great, I just left some very tiny nitpicks 😄
docs/data/date-pickers/date-picker/CustomizationExamplesNoSnap.js
Outdated
Show resolved
Hide resolved
I pushed a small fix to hopefully make the CI happy 🤞 |
Just a little bump here @noraleonte :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for taking care of this! 💙
Co-authored-by: noraleonte <[email protected]>
While checking out the X docs, I noticed that the playground borders seemed too bright against the dark theme, which was a bit off. So, I decided to tweak them a bit and ended up making some other adjustments along the way.
👉 https://deploy-preview-11869--material-ui-x.netlify.app/x/react-date-pickers/date-picker/#customization