Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add polish to the date-picker playground #11869

Merged
merged 7 commits into from
Feb 29, 2024

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Jan 30, 2024

While checking out the X docs, I noticed that the playground borders seemed too bright against the dark theme, which was a bit off. So, I decided to tweak them a bit and ended up making some other adjustments along the way.

Current New
Screenshot 2024-01-30 at 16 02 19 Screenshot 2024-02-07 at 11 37 49

👉 https://deploy-preview-11869--material-ui-x.netlify.app/x/react-date-pickers/date-picker/#customization

@zanivan zanivan added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! labels Jan 30, 2024
@zanivan zanivan self-assigned this Jan 30, 2024
@zanivan
Copy link
Contributor Author

zanivan commented Jan 30, 2024

@noraleonte I just made some stray tweaks, please let me know if anything needs to be fixed, since this is my first PR for X :)

@mui-bot
Copy link

mui-bot commented Jan 30, 2024

Deploy preview: https://deploy-preview-11869--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 0930b5e

Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up, @zanivan 💯 🎉
Looks great, I just left some very tiny nitpicks 😄

docs/src/modules/components/CustomizationPlayground.tsx Outdated Show resolved Hide resolved
typescript Outdated Show resolved Hide resolved
@noraleonte
Copy link
Contributor

I pushed a small fix to hopefully make the CI happy 🤞

@zanivan
Copy link
Contributor Author

zanivan commented Feb 29, 2024

Just a little bump here @noraleonte :)

Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for taking care of this! 💙

@zanivan zanivan changed the title [docs] Polishing out the date-picker playground [docs] Add polish to the date-picker playground Feb 29, 2024
@zanivan zanivan merged commit f42e9b7 into mui:next Feb 29, 2024
17 checks passed
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants