Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popover][Menu] Ensure stickIfOpen is reset to true correctly #1548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Mar 10, 2025

When impatiently clicking the trigger of Menu or Popover, it would unexpectedly close the popup if either had already been opened and the PATIENT_CLICK_THRESHOLD time had elapsed the first time before deciding to click when either is opened on hover.

Steps:

  1. Open on hover
  2. Wait >500ms
  3. Dismiss
  4. Re-open on hover
  5. Click within 500ms
  6. Now sticks (previously would close)

@atomiks atomiks added component: menu This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work component: popover This is the name of the generic UI component, not the React module! labels Mar 10, 2025
Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 82db337
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/67ce938294bdd80008c87125
😎 Deploy Preview https://deploy-preview-1548--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module! component: popover This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant