Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add options scope config to debugging uncaught requests #186

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rtalvarez
Copy link

Hello all,

I recently had the need to follow the instructions under Debugging uncaught requests, and more specifically under Set the Service-Worker-Allowed response header

After adding the appropriate header in my server, I bumped my head for a while wondering why it still wasn't working, until I realized I needed to provide the additional piece of config to my worker setup:

options: { scope: '/' }

I was wondering why this wasn't mentioned in the docs, not sure if there's a reason. If not, I thought it'd be pretty neat if the docs mentioned the need for this (although not sure if it would be needed in all cases, or was just a need for my particular setup). Anyway, I added a small section in there that mentions it

@vercel
Copy link

vercel bot commented Feb 23, 2022

@rtalvarez is attempting to deploy a commit to the MSW Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant