Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(browser): add failing tests for xhr upload events #2262

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gmarcos87
Copy link

This PR shows that the upload events in xhr are not being fired correctly.

@gmarcos87 gmarcos87 changed the title XHR - upload events are not triggered test(browser): add failing tests for xhr upload events Sep 4, 2024
@kettanaito
Copy link
Member

Thanks for submitting this, @gmarcos87!

If you experience this in the browser, then I'm afraid there's little we can do. MSW uses a Service Worker to intercept XHR in the browser, so if the request doesn't fire its upload events, it's either an issue with the request or the way how the Service Worker API handles responses to XHR.

We've implemented the proper upload event support to XHR in Node.js though! (if using msw/node). Those fixes are not a part of MSW just yet.

@kettanaito
Copy link
Member

I'm fairly confident this is going to be fixed by https://github.com/mswjs/interceptors/releases/tag/v0.34.2.

@gmarcos87
Copy link
Author

I'm fairly confident this is going to be fixed by https://github.com/mswjs/interceptors/releases/tag/v0.34.2.

Thank you very much @kettanaito! Tomorrow I will test the release on my source code and see if that fixes the tests.

@kettanaito
Copy link
Member

@gmarcos87, a new version of MSW will release today containing that fix. Let me know how it goes!

@gmarcos87
Copy link
Author

Ok, I tested it and it works! But...
It works the first time I run the tests, if I do it in “watch” mode the following re-runs of the tests don't trigger the callback. I have updated both msw and re-generated the service worker.

@kettanaito
Copy link
Member

@gmarcos87, are these browser or Node.js tests? Please share a reproduction repo. This may have something to do with your test's setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants