Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip parsing GraphQL requests if the request url doesn't match #1871

Merged
merged 6 commits into from
Nov 24, 2023

Commits on Nov 19, 2023

  1. fix(graphqlhandler): avoid parse error when req url doesn't match

    When we have a specified graphql endpoint, and that endpoint doesn't match we don't need to parse
    the request at all.  This avoids weird console.errors that may apply when the user mixes rest and d
    graphql handlers. This fix cannot be easily applied to the base `graphql` handler since it doesn't
    have a dedicated endpoint, but that's a decent tradeoff for now, as it provides a way to better
    scope those errors and avoid user confusion in the short term.
    
    Maybe we should consider forcing graphql calls to `link` a specific endpoint prior to handling which
    would avoid this issue
    mattcosta7 committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    74a83cf View commit details
    Browse the repository at this point in the history
  2. test: update handler test

    mattcosta7 committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    7c06d30 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e44a35b View commit details
    Browse the repository at this point in the history
  4. test: add post/get combos

    mattcosta7 committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    3181d5f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    064cfe1 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Configuration menu
    Copy the full SHA
    69be062 View commit details
    Browse the repository at this point in the history