-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6349 fix double confirm #6753
base: v2.6.0-RC
Are you sure you want to change the base?
6349 fix double confirm #6753
Conversation
@@ -34,7 +34,7 @@ | |||
["TRANSGENDER_MALE", "Transgender Male"], | |||
["TRANSGENDER_FEMALE", "Transgender Female"], | |||
["NON_BINARY", "Non-binary"], | |||
["UNKOWN", "Unknown"] | |||
["UNKNOWN", "Unknown"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed this in the edit schema last week but forgot the create schema π
Bundle size differenceComparing this PR to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a beaut!
I did notice that when editing a patient, if a field is edited and not blurred before clicking one of the other tabs, the information won't save/confirm for saving.
This is not related to your issue or fix though, so I'll raise it separately!
Actually - this looks like it's only if it's an immediate change of tab - after half a second it prompts the save! |
Fixes #6349
π©π»βπ» What does this PR do?
JSON forms has an isDirty check on navigation baked in. So we don't need the extra custom one :)
π Any notes for the reviewer?
π§ͺ Testing
π Documentation
1.
2.
π Reviewer Checklist
The PR Reviewer(s) should fill out this section before approving the PR
Breaking Changes
Issue Review
Tests Pass