Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2897 navigate to returns #6752

Open
wants to merge 4 commits into
base: v2.6.0-RC
Choose a base branch
from
Open

Conversation

fergie-nz
Copy link
Contributor

Fixes #6481

πŸ‘©πŸ»β€πŸ’» What does this PR do?

Adds navigate to supplier and customer returns when they are created from inbound and outbound returns respectively

πŸ’Œ Any notes for the reviewer?

πŸ§ͺ Testing

  • Create an inbound shipment
  • Select some lines and choose to return them
  • click 'ok' on the modal
  • See navigated to Supplier Returns
  • Confirm the same works with Outbound shipment and Customer Returns

πŸ“ƒ Documentation

  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour

πŸ“ƒ Reviewer Checklist

The PR Reviewer(s) should fill out this section before approving the PR

Breaking Changes

  • No Breaking Changes in the Graphql API
  • Technically some Breaking Changes but not expected to impact any integrations

Issue Review

  • All requirements in original issue have been covered
  • A follow up issue(s) have been created to cover additional requirements

Tests Pass

  • Postgres
  • SQLite
  • Frontend

@github-actions github-actions bot added this to the v2.6.0-RC5 milestone Feb 28, 2025
@fergie-nz fergie-nz changed the base branch from develop to v2.6.0-RC February 28, 2025 00:53
@@ -543,6 +544,7 @@ export const UpdateCustomerReturnLinesDocument = gql`
... on InvoiceNode {
__typename
id
invoiceNumber
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to update api to find invoice number when updating lines

outboundShipmentId,
customerReturnLines,
});
return typeof returnOp === "number" ? returnOp : returnOp.invoiceNumber;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awaiting update / insert and then converting to always return a number to be consumer focussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I am not notified when a supplier return is created (and it's only in nw status so never gets finalised...)
1 participant