(Fix) autofill / extensions and restore persistent storage location #686
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the existing sqlite DB path maintains backwards compatibility with the existing persistent store. Assuming the DB path should be maintained from v0.16 This should fix issues reported where there are no entries for the repository.
a-feld
force-pushed
the
fix-persistent-storage
branch
2 times, most recently
from
9afc7b3 to
5adc0e9
Compare
App extensions access the persistent storage. From the refactor, the persistent storage "setup" is no longer called which breaks the extension and the pass auto fill. This commit moves the persistent storage setup into the init for the shared storage, which should be called once for the first read access or in preparation for a write. As a result, extensions should now work as expected.
a-feld
force-pushed
the
fix-persistent-storage
branch
from
5adc0e9 to
3d4b081
Compare
|
Thanks! Will submit the fix to App Store today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #685
Fixes: #684
Fixes: #683
There are 2 changes here to restore autofill / extension functionality
Add persistent DB path for extension access
Using the existing sqlite DB path maintains backwards compatibility with
the existing persistent store.
Assuming the DB path should be maintained from v0.16
This should fix issues reported where there are no entries for the
repository.
Move persistence controller setup into the init
App extensions access the persistent storage. From the refactor, the
persistent storage "setup" is no longer called which breaks the
extension and the pass auto fill.
This commit moves the persistent storage setup into the init for the
shared storage, which should be called once for the first read access or
in preparation for a write.
As a result, extensions should now work as expected.
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-25.at.22.48.41.mp4