Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ask.el -> ask-mode.el and add file header #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yuanwang-wf
Copy link

Greeting, thank you for putting this project on github, and CS103 2024/25 lectures on the internet.

I think this PR makes install ask mode in emacs easier.

once again, thank you for all the work.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
yuanwang-wf Yuan Wang

Verified

This commit was signed with the committer’s verified signature. The key has expired.
yuanwang-wf Yuan Wang
@fredrikNordvallForsberg
Copy link
Member

Could you briefly explain why this makes it easier to install ask?

I spoke to @pigworker, and they were reluctant to accept this pull request during the semester, as it would mean having to change the file name in their .emacs file.

@yuanwang-wf
Copy link
Author

yuanwang-wf commented Mar 4, 2025

Could you briefly explain why this makes it easier to install ask?

I can try. I was packaging this with nix using nix's melpa build. I think under the hook, it tries to package all el files (in this case just one file) as a melpa package. The build failed because

  1. the file doesn't have a file header ;;; file-name.el --- some comment
  2. at the end of file, file (provide 'ask-mode), but the file's name is not ask-mode

I based the change from agda2-mode https://github.com/agda/agda/blob/master/src/data/emacs-mode/agda2-mode.el

We can wait until the semester finish or close this PR. I can keep this PR up to date

@fredrikNordvallForsberg
Copy link
Member

Thanks for explaining! I think merging after the semester finishes seems like a good plan, if you are happy with that?

@yuanwang-wf
Copy link
Author

that sounds good to me, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants