Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExtensionCodec example so it recurses. #225

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Fix ExtensionCodec example so it recurses. #225

merged 1 commit into from
Apr 4, 2023

Conversation

jcc10
Copy link
Contributor

@jcc10 jcc10 commented Apr 1, 2023

Fixes example so data doesn't get lost in recursion.

Creates valid workaround for #138

Spent about a hour before I realized the example was broken. 🤦‍♀️

Fixes example so data doesn't get lost in recursion.

Creates valid workaround for msgpack#138
@gfx
Copy link
Member

gfx commented Apr 4, 2023

Thank you! Yes, you are right, and I have also experienced the same issue before. It is a wrong design of the current interface, which I'd love to fix in the future.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (e615511) 98.58% compared to head (29a970f) 98.58%.

❗ Current head 29a970f differs from pull request most recent head 07900e5. Consider uploading reports for the commit 07900e5 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #225   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          16       16           
  Lines         990      990           
  Branches      195      195           
=======================================
  Hits          976      976           
  Misses         14       14           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gfx gfx merged commit 6e22414 into msgpack:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants