-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No ES6 Map support? #138
Comments
Thank you for your report. This is the specification and won't be fixed because MessagePack is designed to communicate in multi-languages. I won't add any flavors by default. However, any JavaScript programs use lots of non-primitive objects, so the MessagePack spec has extensions. Also, I'd like to add extensions to handle non-primitive objects like ES2015's Map, just like as browsers do. |
Sorry, where in the spec does it say something incompatible with |
To concur with what @joshyrobot is saying, what we're looking for is not so much a way to encode maps in addition to objects, we're looking for a way to encode maps instead of objects— something like an alternate mode in which maps are always created and consumed and vanilla javascript objects are never created or consumed. |
Fixes example so data doesn't get lost in recursion. Creates valid workaround for msgpack#138
If I run the following test program with msgpack-javascript 2.1.0:
The output is:
Conclusion: Asking msgpack-javascript to encode a Map causes it to encode it as if it were an empty object.
Supporting Maps in some capacity would be good because if anything it is better to store Maps in msgpack than to store objects. Sometimes deserializing in JavaScript can cause problems or even security flaws if keys overwrite "special" javascript objects like
hasOwnProperty
or__proto__
. Here is an example of such a problem. I suspect msgpack-javascript itself will not have any such security flaws, but it is easy for client code to have such security flaws and the security issues can be sidestepped by using Maps instead of objects.The text was updated successfully, but these errors were encountered: