Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that update tasks resolve dependencies from their own dir #63

Closed
wants to merge 1 commit into from
Closed

Ensure that update tasks resolve dependencies from their own dir #63

wants to merge 1 commit into from

Conversation

romainmenke
Copy link
Member

No description provided.

@romainmenke romainmenke changed the title update tasks Ensure that update tasks resolve dependencies from their own dir Jul 17, 2024
mhassan1
mhassan1 requested changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@mhassan1 mhassan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this PR needed? I would think require.resolve("@formatjs/intl-datetimeformat/locale-data/en.js") would always have the same result as require.resolve("@formatjs/intl-datetimeformat/locale-data/en.js", { paths: [__dirname] }).

@romainmenke romainmenke marked this pull request as draft July 17, 2024 18:07
@romainmenke
Copy link
Member Author

Sorry should have been a draft :)

Had this open locally and wanted to save state before doing code review.

@romainmenke romainmenke deleted the update-tasks--empathetic-sea-squirt-934683846c branch September 23, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhassan1 mhassan1 mhassan1 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romainmenke @mhassan1