Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSLNodeBuilder: Check texture type when declaring usampler3D/sampler3D uniforms #30608

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

zonkypop
Copy link
Contributor

Currently in the GLSLNodeBuilder, all Data3DTexture's are being declared as sampler3D. This PR adds the same checks which DataTexture have for their type, so usampler3D and isampler3D are now declared for their respective types

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.65
78.39
336.65
78.39
+0 B
+0 B
WebGPU 522.53
145.06
522.57
145.08
+39 B
+17 B
WebGPU Nodes 522
144.96
522.04
144.97
+39 B
+17 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.7
112.26
465.7
112.26
+0 B
+0 B
WebGPU 593
160.69
593.04
160.71
+39 B
+15 B
WebGPU Nodes 548.13
150.12
548.16
150.14
+39 B
+17 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant