Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: improve Jsdoc types #30603

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Docs: improve Jsdoc types #30603

merged 1 commit into from
Feb 24, 2025

Conversation

s-rigaud
Copy link
Contributor

Description

Fix type errors found while parsing the project with TS

Copy link

github-actions bot commented Feb 24, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.65
78.39
336.65
78.39
+0 B
+0 B
WebGPU 522.33
145
522.34
145
+5 B
+2 B
WebGPU Nodes 521.8
144.89
521.8
144.89
+5 B
+2 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.7
112.26
465.7
112.26
+0 B
+0 B
WebGPU 592.8
160.62
592.81
160.62
+5 B
+3 B
WebGPU Nodes 547.93
150.06
547.93
150.06
+5 B
+3 B

@Mugen87 Mugen87 added this to the r174 milestone Feb 24, 2025
@Mugen87 Mugen87 merged commit f37f997 into mrdoob:dev Feb 24, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants