Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDSLoader: Fix incorrect alpha when loading 24-bit uncompressed textures. #30598

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

miere43
Copy link
Contributor

@miere43 miere43 commented Feb 23, 2025

Description

When loading 24-bit uncompressed DDS texture, alpha value was mistakingly set to 1 instead of 255, resulting in almost fully transparent mesh when using BasicMeshMaterial with transparent: true option.

I have updated webgl_loader_texture_dds.html to include transparent: true, so bug could be seen in practice:

Before fix: NOTE: you cannot see the cube in bottom left corner because it has alpha of 1 (of 255).
After fix: Now cube can be seen, as is has alpha of 255.

Screenshot was regenerated with npm run make-screenshot webgl_loader_texture_dds, but there are no visible changes (I can delete this change).

@Mugen87 Mugen87 added this to the r174 milestone Feb 23, 2025
@Mugen87 Mugen87 merged commit c8b3e44 into mrdoob:dev Feb 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants