Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLBackend: Fix depth formats. #30422

Merged
merged 1 commit into from
Jan 29, 2025
Merged

WebGLBackend: Fix depth formats. #30422

merged 1 commit into from
Jan 29, 2025

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 29, 2025

Related issue: #30387

Description

This was found by @cabanier in #30387 (comment) 🎉 . The WebGL 2 backend of WebGPURenderer did not use the correct internal format when using depth textures with UnsignedIntType. Instead of gl.DEPTH24_STENCIL8, it should be gl.DEPTH_COMPONENT24.

Besides, the PR adds the missing support for THREE.UnsignedShortType.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.27
78.29
336.27
78.29
+0 B
+0 B
WebGPU 516.71
143.46
516.75
143.47
+47 B
+5 B
WebGPU Nodes 516.17
143.36
516.22
143.36
+47 B
+4 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.25
112.13
465.25
112.13
+0 B
+0 B
WebGPU 588.71
159.63
588.76
159.63
+47 B
+5 B
WebGPU Nodes 544.1
149.19
544.14
149.2
+47 B
+4 B

@Mugen87 Mugen87 added this to the r173 milestone Jan 29, 2025
@Mugen87 Mugen87 merged commit 7d4b4ae into mrdoob:dev Jan 29, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant