Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BasisTextureLoader: Documentation and cleanup. #16675

Merged
merged 5 commits into from
Jun 4, 2019
Merged

BasisTextureLoader: Documentation and cleanup. #16675

merged 5 commits into from
Jun 4, 2019

Conversation

donmccurdy
Copy link
Collaborator

  • Added documentation
  • Better error propagation
  • Use FileLoader and LoadingManager
  • Don't use ES6 classes
  • Applied eslint

/cc #16524

@donmccurdy donmccurdy mentioned this pull request Jun 4, 2019
Closed
12 tasks
@mrdoob mrdoob added this to the r106 milestone Jun 4, 2019
@mrdoob mrdoob merged commit 232c1dc into mrdoob:dev Jun 4, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jun 4, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r106
Development

Successfully merging this pull request may close these issues.
2 participants
@donmccurdy @mrdoob