[searchfox_api] Handle elements without line number id #4798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminmah
changed the title
syn_comment spans in get_line_number()
Comment on lines
+32
to
+33
| for e in all_descendants | ||
| if "id" in e.attrib and e.attrib["id"].startswith("line-") |
There was a problem hiding this comment.
This does not consider cases where the last element is a code block, not a code line. We may need to consider such cases.
|
Closing in favour of #4844 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4796.
We were encountering this error when running
code_review_tool_evaluator, and it was due to elements that didn't have an ID, for example:<span class="syn_comment"># Can't use argparse default or this choice will be always present</span>which was from recursively getting the descendants.I've added a conditional to only get the descendants for elements with the attribute
data-nesting-symif it contains anidstarting withline-.