More arbitrary c8 ignores #4305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we add code, more existing code suddenly gets marked as uncovered by unit tests intermittently. This adds c8 ignore comments for everything that turned up when running npm test -- --no-cache --runInBand But I really hope this gets fixed upstream soon, because this isn't sustainable. For more context, see: #4234 And the (hopefully correct) upstream issue: istanbuljs/v8-to-istanbul#236
flozia
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we add code, more existing code suddenly gets marked as uncovered by unit tests intermittently. This adds c8 ignore comments for everything that turned up when running
npm test -- --no-cache --runInBand
But I really hope this gets fixed upstream soon, because this isn't sustainable.
For more context, see:
#4234
And the (hopefully correct) upstream issue:
istanbuljs/v8-to-istanbul#236
Ugh. I feel dirty.