Bump Transformer v4.49.0 #1735
Merged
Bump Transformer v4.49.0 #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuuCi
force-pushed
the
bump-transformer-v4.49.0
branch
from
2d8bcb8 to
a0a1eaa
Compare
added 2 commits
March 11, 2025 12:44
dakinggg
reviewed
Mar 11, 2025
added 3 commits
March 11, 2025 14:09
dakinggg
reviewed
Mar 11, 2025
There was a problem hiding this comment.
Basically LGTM! Please update the PR description to note that after this PR, the MPT models on the huggingface hub will no longer be usable with trust_remote_code=True and older foundry versions will need to be used for that.
Please also adjust the MPT error to say that it is no longer supported by foundry.
added 2 commits
March 11, 2025 14:57
dakinggg
reviewed
Mar 11, 2025
added 3 commits
March 11, 2025 15:01
dakinggg
reviewed
Mar 11, 2025
dakinggg
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨🚨🚨 MPT models on the huggingface hub will no longer be usable with trust_remote_code=True and older foundry versions will need to be used for that. 🚨🚨🚨
A couple of interesting notes:
Transformer tokenizers have added an extra_special_tokens attribute + made a new object
AddedTokensfor special tokens.Seems we have to explicitly set torch_dtype due to this, where transformer will explicitly converts the torch_dtype to a string for JSON serialization.
Looks like they've gotten rid of LlamaFlashAttention2 and refactored Attention:
huggingface/transformers#35235
Seems like our test was actually hitting this strange interaction:
huggingface/transformers#30305