Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Transformer v4.49.0 #1735

Merged
merged 53 commits into from
Mar 12, 2025
Merged

Bump Transformer v4.49.0 #1735

merged 53 commits into from
Mar 12, 2025

Conversation

KuuCi
Copy link
Contributor

@KuuCi KuuCi commented Mar 5, 2025

🚨🚨🚨 MPT models on the huggingface hub will no longer be usable with trust_remote_code=True and older foundry versions will need to be used for that. 🚨🚨🚨

A couple of interesting notes:

Transformer tokenizers have added an extra_special_tokens attribute + made a new object AddedTokens for special tokens.

Seems we have to explicitly set torch_dtype due to this, where transformer will explicitly converts the torch_dtype to a string for JSON serialization.

Looks like they've gotten rid of LlamaFlashAttention2 and refactored Attention:
huggingface/transformers#35235

Seems like our test was actually hitting this strange interaction:
huggingface/transformers#30305

@KuuCi KuuCi force-pushed the bump-transformer-v4.49.0 branch from 2d8bcb8 to a0a1eaa Compare March 6, 2025 18:46
@KuuCi KuuCi requested a review from dakinggg March 11, 2025 20:52
@KuuCi KuuCi marked this pull request as ready for review March 11, 2025 21:45
@KuuCi KuuCi requested review from a team as code owners March 11, 2025 21:45
@KuuCi KuuCi requested a review from dakinggg March 11, 2025 21:45
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM! Please update the PR description to note that after this PR, the MPT models on the huggingface hub will no longer be usable with trust_remote_code=True and older foundry versions will need to be used for that.

Please also adjust the MPT error to say that it is no longer supported by foundry.

Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change models in yamls to 8b, otherwise LGTM!

@KuuCi KuuCi merged commit a0ae025 into main Mar 12, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants