Handling Popup window's script injection #956
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
IWindowPolicy
withDefaultPopupWindowPolicy
to not inject scripts into popups - opened window via thewindow.open
JS call and track theWindow
's andContentPane
's child popup windows to enable closing windows if their parent is closed in case of popups.Testably
andTestableIO
upgrades.Also please be aware I have an another solution for the script inejction popup windows where I am using the
WebWindowOptions
to create aFloatingOnly
window instead of creating aPopupWindow
class. Commit can be found here: [https://github.com/morganstanley/ComposeUI/commit/f41a19950dfa32cd5acc2682467650f0e039eb5f]